Skip to content

clang-tidy: namespace minor fixes #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdschubert merged 2 commits into from
Jan 4, 2022
Merged

clang-tidy: namespace minor fixes #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0220885
add comments to namespace ends
Dec 22, 2021
34d7495
Merge branch 'development' into f-ClangTidyNamespaceMinorFixes
pdschubert Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions include/phasar/PhasarClang/ClangController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@
#ifndef PHASAR_PHASARCLANG_CLANGCONTROLLER_H_
#define PHASAR_PHASARCLANG_CLANGCONTROLLER_H_

namespace clang {
namespace tooling {
namespace clang::tooling {
class CommonOptionsParser;
}
} // namespace clang
} // namespace clang::tooling

namespace psr {

Expand Down
6 changes: 3 additions & 3 deletions include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/ConstantHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@

namespace llvm {
class Value;
}
} // namespace llvm

namespace psr {
bool isConstant(const llvm::Value *val);
}
bool isConstant(const llvm::Value *Val);
} // namespace psr

#endif
2 changes: 1 addition & 1 deletion include/phasar/PhasarLLVM/Pointer/TypeGraphs/CachedTypeGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

namespace llvm {
class StructType;
}
} // namespace llvm

namespace psr {
class CachedTypeGraph : public TypeGraph<CachedTypeGraph> {
Expand Down
2 changes: 1 addition & 1 deletion include/phasar/PhasarLLVM/Pointer/TypeGraphs/LazyTypeGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

namespace llvm {
class StructType;
}
} // namespace llvm

namespace psr {
class LazyTypeGraph : public TypeGraph<LazyTypeGraph> {
Expand Down
2 changes: 1 addition & 1 deletion include/phasar/PhasarLLVM/Pointer/TypeGraphs/TypeGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace llvm {
class StructType;
}
} // namespace llvm

namespace psr {
template <class ConcreteTypeGraph> class TypeGraph {
Expand Down
3 changes: 2 additions & 1 deletion include/phasar/Utils/LLVMCXXShorthands.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@

namespace psr {
bool isTouchVTableInst(const llvm::StoreInst *Store);
}
} // namespace psr

#endif
2 changes: 1 addition & 1 deletion lib/PhasarLLVM/Utils/BasicBlockOrdering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ bool BasicBlockOrdering::mustComeBefore(const llvm::Instruction *LHS,
return getDom(LHS->getFunction()).dominates(LHS, RHS);
}

} // namespace psr
} // namespace psr
2 changes: 1 addition & 1 deletion lib/Utils/LLVMCXXShorthands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ bool isTouchVTableInst(const llvm::StoreInst *Store) {
} /* end vtable set-up instruction */
return false;
}
} // namespace psr
} // namespace psr