clang-tidy: Fix IDEXTaint#456
Merged
pdschubert merged 7 commits intodevelopmentfrom Jan 4, 2022
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fabianbs96
reviewed
Dec 23, 2021
Member
fabianbs96
left a comment
fabianbs96
left a comment
There was a problem hiding this comment.
Looks good so far; just some minor things
Comment on lines
+52
to
+53
| EdgeFunctionComposer(EdgeFunctionPtrType &F, EdgeFunctionPtrType &G) | ||
| : EFComposerId(++CurrEFComposerId), F(F), G(G) {} |
Member
There was a problem hiding this comment.
Suggested change
| EdgeFunctionComposer(EdgeFunctionPtrType &F, EdgeFunctionPtrType &G) | |
| : EFComposerId(++CurrEFComposerId), F(F), G(G) {} | |
| EdgeFunctionComposer(EdgeFunctionPtrType F, EdgeFunctionPtrType G) | |
| : EFComposerId(++CurrEFComposerId), F(std::move(F)), G(std::move(G)) {} |
| bool isLLVMZeroValue(const llvm::Value *V) const { | ||
| if (V && V->hasName()) { | ||
| // checks if V's name start with "zero_value" | ||
| return V->getName().find(LLVMZeroValueInternalName) != |
Member
There was a problem hiding this comment.
Suggested change
| bool isLLVMZeroValue(const llvm::Value *V) const { | |
| if (V && V->hasName()) { | |
| // checks if V's name start with "zero_value" | |
| return V->getName().find(LLVMZeroValueInternalName) != | |
| bool isLLVMZeroValue(const llvm::Value *V) const { | |
| return V == getInstance(); | |
| } |
vulder
force-pushed
the
f-ClangTidyFixIDEXTaint
branch
from
493ed9c to
42f91ce
Compare
…alysis/ComposeEdgeFunction.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…alysis/JoinEdgeFunction.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vulder
requested changes
Dec 26, 2021
pdschubert
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please merge after #455