clang-tidy: Fix IDE TSA by MMory · Pull Request #459 · secure-software-engineering/phasar

MMory · 2021-12-23T16:56:27Z

~~please merge after #458~~

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

vulder · 2021-12-26T09:16:18Z

-                           std::shared_ptr<EdgeFunction<l_t>> G, l_t bot)
-        : EdgeFunctionComposer<l_t>(F, G), botElement(bot){};
+                           std::shared_ptr<EdgeFunction<l_t>> G, l_t Bot)
+        : EdgeFunctionComposer<l_t>(F, G), BotElement(Bot){};


Suggested change

: EdgeFunctionComposer<l_t>(F, G), BotElement(Bot){};

: EdgeFunctionComposer<l_t>(F, G), BotElement(Bot){};

vulder · 2021-12-26T09:16:59Z

    TSEdgeFunctionComposer(std::shared_ptr<EdgeFunction<l_t>> F,
-                           std::shared_ptr<EdgeFunction<l_t>> G, l_t bot)
-        : EdgeFunctionComposer<l_t>(F, G), botElement(bot){};
+                           std::shared_ptr<EdgeFunction<l_t>> G, l_t Bot)


We probably should move F and G into the EdgeFunctionComposer

True. But this would also require more refactoring due to the types of the member variables in EdgeFunctionComposer.

vulder · 2021-12-26T09:21:39Z

@@ -142,11 +141,11 @@ OpenSSLEVPKDFDescription::OpenSSLEVTKDFToken
 OpenSSLEVPKDFDescription::funcNameToToken(const std::string &F) {


…StateDescriptions/OpenSSLEVPKDFCTXDescription.h Co-authored-by: Florian Sattler <vuld3r@gmail.com>

…nto f-ClangTidyFixIDETSA

github-actions · 2022-01-05T07:54:14Z

+  [[nodiscard]] bool isFactoryFunction(const std::string &FuncName) const override;
+  [[nodiscard]] bool isConsumingFunction(const std::string &FuncName) const override;


[clang-format] _{reported by reviewdog 🐶}

Suggested change

[[nodiscard]] bool isFactoryFunction(const std::string &FuncName) const override;

[[nodiscard]] bool isConsumingFunction(const std::string &FuncName) const override;

[[nodiscard]] bool

isFactoryFunction(const std::string &FuncName) const override;

[[nodiscard]] bool

isConsumingFunction(const std::string &FuncName) const override;

MMory requested review from fabianbs96, pdschubert and vulder December 23, 2021 16:56

github-actions Bot reviewed Dec 23, 2021

View reviewed changes

MMory mentioned this pull request Dec 23, 2021

clang-tidy: Fix IDE solver #460

Merged

clang-tidy fixes for IDE TSA

038bddb

vulder force-pushed the f-ClangTidyFixIDETSA branch from 6c90deb to 038bddb Compare December 24, 2021 13:23

vulder requested changes Dec 26, 2021

View reviewed changes

pdschubert and others added 4 commits January 5, 2022 08:48

Update include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/Type…

b63c091

…StateDescriptions/OpenSSLEVPKDFCTXDescription.h Co-authored-by: Florian Sattler <vuld3r@gmail.com>

Merge branch 'development' into f-ClangTidyFixIDETSA

4880883

minor fixes

3a65710

Merge branch 'f-ClangTidyFixIDETSA' of github.com:pdschubert/phasar i…

939c79a

…nto f-ClangTidyFixIDETSA

github-actions Bot reviewed Jan 5, 2022

View reviewed changes

pdschubert merged commit 7f3549c into development Jan 5, 2022

pdschubert deleted the f-ClangTidyFixIDETSA branch January 5, 2022 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clang-tidy: Fix IDE TSA#459

clang-tidy: Fix IDE TSA#459
pdschubert merged 5 commits intodevelopmentfrom
f-ClangTidyFixIDETSA

MMory commented Dec 23, 2021 •

edited by vulder

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vulder Dec 26, 2021

Uh oh!

vulder Dec 26, 2021

Uh oh!

pdschubert Jan 5, 2022

Uh oh!

Uh oh!

vulder Dec 26, 2021

Uh oh!

github-actions Bot Jan 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	: EdgeFunctionComposer<l_t>(F, G), BotElement(Bot){};
	: EdgeFunctionComposer<l_t>(F, G), BotElement(Bot){};

		@@ -142,11 +141,11 @@ OpenSSLEVPKDFDescription::OpenSSLEVTKDFToken
		OpenSSLEVPKDFDescription::funcNameToToken(const std::string &F) {

		[[nodiscard]] bool isFactoryFunction(const std::string &FuncName) const override;
		[[nodiscard]] bool isConsumingFunction(const std::string &FuncName) const override;

Conversation

MMory commented Dec 23, 2021 • edited by vulder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vulder Dec 26, 2021

Choose a reason for hiding this comment

Uh oh!

vulder Dec 26, 2021

Choose a reason for hiding this comment

Uh oh!

pdschubert Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vulder Dec 26, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MMory commented Dec 23, 2021 •

edited by vulder

Loading