Skip to content

LCA improvements#471

Merged
pdschubert merged 10 commits intodevelopmentfrom
f-LCAImprovements
Jan 12, 2022
Merged

LCA improvements#471
pdschubert merged 10 commits intodevelopmentfrom
f-LCAImprovements

Conversation

@fabianbs96
Copy link
Copy Markdown
Member

Several updates in the IDELinearConstantAnalysis

@fabianbs96 fabianbs96 changed the title F LCA improvements LCA improvements Jan 5, 2022
@fabianbs96 fabianbs96 self-assigned this Jan 5, 2022
@fabianbs96 fabianbs96 requested a review from pdschubert January 5, 2022 12:42
@pdschubert
Copy link
Copy Markdown
Member

Thanks for the improvements. However, the unit tests cannot be build since a required operator== is missing:

-c ../unittests/PhasarLLVM/ControlFlow/LLVMBasedICFGGlobCtorDtorTest.cpp
In file included from ../unittests/PhasarLLVM/ControlFlow/LLVMBasedICFGGlobCtorDtorTest.cpp:10:
../external/googletest/googletest/include/gtest/gtest.h:1545:11: error: invalid operands to binary expression ('const int' and 'const psr::LatticeDomain<long>')
  if (lhs == rhs) {

@pdschubert
Copy link
Copy Markdown
Member

I'm working on a fix.

@pdschubert pdschubert merged commit de7532a into development Jan 12, 2022
@pdschubert pdschubert deleted the f-LCAImprovements branch January 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants