Skip to content

Fix Dangling Pointer in IDESolver #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdschubert merged 5 commits into from
Jan 7, 2022
Merged

Fix Dangling Pointer in IDESolver #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fab2c7
The fix
fabianbs96 Jan 7, 2022
7e95637
Update IDESolver.h
pdschubert Jan 7, 2022
bc09b17
Update IDESolver.h
pdschubert Jan 7, 2022
273bde6
Readd the fix
fabianbs96 Jan 7, 2022
563b5c2
avoid unnecessary table copies
pdschubert Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Solver/IDESolver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,8 +892,8 @@ class IDESolver
for (n_t n : Values) {
for (n_t SP : ICF->getStartPointsOf(ICF->getFunctionOf(n))) {
using TableCell = typename Table<d_t, d_t, EdgeFunctionPtrType>::Cell;
Table<d_t, d_t, EdgeFunctionPtrType> LookupByTarget;
LookupByTarget = JumpFn->lookupByTarget(n);
Table<d_t, d_t, EdgeFunctionPtrType> &LookupByTarget =
JumpFn->lookupByTarget(n);
for (const TableCell &SourceValTargetValAndFunction :
LookupByTarget.cellSet()) {
d_t dPrime = SourceValTargetValAndFunction.getRowKey();
Expand Down Expand Up @@ -1098,7 +1098,9 @@ class IDESolver
// return site using the composed function
auto RevLookupResult = JumpFn->reverseLookup(c, d4);
if (RevLookupResult) {
for (const auto &ValAndFunc : RevLookupResult->get()) {
llvm::SmallVector<std::pair<d_t, EdgeFunctionPtrType>, 2> ResCopy(
RevLookupResult->get().begin(), RevLookupResult->get().end());
for (const auto &ValAndFunc : ResCopy) {
EdgeFunctionPtrType f3 = ValAndFunc.second;
if (!f3->equal_to(AllTop)) {
d_t d3 = ValAndFunc.first;
Expand Down
2 changes: 1 addition & 1 deletion include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Solver/JumpFunctions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ template <typename AnalysisDomainTy, typename Container> class JumpFunctions {
* The return value is a set of records of the form
* (sourceVal,targetVal,edgeFunction).
*/
Table<d_t, d_t, EdgeFunctionPtrType> lookupByTarget(n_t Target) {
Table<d_t, d_t, EdgeFunctionPtrType> &lookupByTarget(n_t Target) {
return NonEmptyLookupByTargetNode[Target];
}

Expand Down