Redesign ICFG#515
Merged
pdschubert merged 22 commits intodevelopmentfrom Nov 21, 2022
Merged
Conversation
…but no that it is there, we should use it
…ng/phasar into f-RedesignICFG
…ibility + simplify the implementation of LLVMBasedICFG::getCalleesOfCallAt/getCallersOf
pdschubert
approved these changes
Nov 21, 2022
Member
pdschubert
left a comment
pdschubert
left a comment
There was a problem hiding this comment.
Thanks, Fabian.
Most of this looks pretty good. But we should definitely add some performance benchmark for the various types of analysis implemented in PhASAR sometime soon. Some of the changes introduce lots of complexity and therefore, we should be able to tell whether certain changes are worth while using regression tests.
We should discuss this in our meeting on Friday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to the CFG and ICFG interfaces similar to the ProjectIRDB in #511.
#511 should be merged first