You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install does not install libraries into ${CMAKE_INSTALL_PREFIX}/lib/phasar, but directly into ${CMAKE_INSTALL_PREFIX}/lib.
So, the linker rpath should point there as well
@MMory What is the desired location when you package phasar? The RPATH should be correct, however, I'm not sure if you want to directly install into lib, so I'll just wanted to point that out.
For testing, I have set CMAKE_INSTALL_PREFIX to /opt/phasar. When doing so, all of phasars libs are installed to /opt/phasar/lib64, but the schema validator is installed to /opt/phasar/lib. The RPATH is set to /opt/phasar/lib64, leaving the schema validator unresolved. lib seems to be hardcoded on the schema validator side. @fabianbs96 what do you think we should do?
fabianbs96
changed the title
Fix RPATH for install
Draft: Fix RPATH for install
Mar 1, 2023
Thanks @MMory for that info. That is indeed an issue.
I marked this PR as draft again, as it seems there is more work to be done.
We should also think about whether it is a good idea to install external dependencies at all
bugSomething isn't workingdependenciesPull requests that update a dependency filetooling
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fabianbs96
added
bug
The install does not install libraries into
${CMAKE_INSTALL_PREFIX}/lib/phasar, but directly into${CMAKE_INSTALL_PREFIX}/lib.So, the linker rpath should point there as well