Skip to content

IFDS Taint analysis summary function for Swift's String.append method #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMory merged 1 commit into from
Mar 23, 2023
Merged

IFDS Taint analysis summary function for Swift's String.append method #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/PhasarLLVM/DataFlow/IfdsIde/Problems/IFDSTaintAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,17 @@ IFDSTaintAnalysis::FlowFunctionPtrType
IFDSTaintAnalysis::getSummaryFlowFunction(
[[maybe_unused]] IFDSTaintAnalysis::n_t CallSite,
[[maybe_unused]] IFDSTaintAnalysis::f_t DestFun) {
// Don't use a special summary
// $sSS1poiyS2S_SStFZ is Swift's String append method
// if concat a tainted string with something else the
// result should be tainted
if (DestFun->getName().equals("$sSS1poiyS2S_SStFZ")) {
const auto *CS = llvm::cast<llvm::CallBase>(CallSite);

return generateFlowIf<d_t>(CallSite, [CS](d_t Source) {
return ((Source == CS->getArgOperand(1)) ||
(Source == CS->getArgOperand(3)));
});
}
return nullptr;
}

Expand Down