Refactor Points-To graph merge logic.#92
Merged
pdschubert merged 1 commit intosecure-software-engineering:masterfrom Feb 13, 2020
Merged
Refactor Points-To graph merge logic.#92pdschubert merged 1 commit intosecure-software-engineering:masterfrom
pdschubert merged 1 commit intosecure-software-engineering:masterfrom
Conversation
Changes the merge logic for points-to graph to avoid re-creating the ValueVertexMap from scratch each time. When merging we can ask boost to provide a mapping so we can simply append to the existing ValueVertexMap instead. For large applications this makes a measurable runtime improvement since the number of merge calls is large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the merge logic for points-to graph to avoid re-creating the
ValueVertexMap from scratch each time. When merging we can ask boost to
provide a mapping so we can simply append to the existing ValueVertexMap
instead. For large applications this makes a measurable runtime
improvement since the number of merge calls is large.
I verified with a small application which does some virtual function calls that the resulting callgraph before/after this change were identical.