Remove securesystemslib.util.TempFile #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
reviewed
Sep 19, 2019
Add persist_temp_file() helper method, which takes a file object and a path and copies the file object's contents into a new file at the path. This is to be used in place of TempFile's move() method, in order that securesystemslib.util.TempFile can be deprecated. Signed-off-by: Joshua Lock <jlock@vmware.com>
So that we can remove securesystemslib.util.TempFile switch to using a combination of tempfile.TemporaryFile() and securesystemslib.util.persist_temp_file() Signed-off-by: Joshua Lock <jlock@vmware.com>
util.TempFile is an incomplete implementation of a Python file object with extra features that are no longer used by any ssl consumers. Any uses should be replaced with one of the methods in tempfile and use of util.persist_temp_file() Fixes secure-systems-lab#180 Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/removessltempfile
branch
from
a6dca67 to
41681fc
Compare
lukpueh
approved these changes
Sep 19, 2019
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
Looks excellent to me! Extra-thanks for the bite-sized commits + the very descriptive commit messages!! 💯 🥇
I also just ran tuf's tests against this branch, using tuf's tip of development plus your patches from theupdateframework/python-tuf#917 and theupdateframework/python-tuf#918, and they pass.
I think we are ready to make a release here and over at tuf (and in-toto too).
Collaborator
Author
|
Excellent news, can't wait to see the releases. Do let me know if there's any way I can help. Otherwise I'll dive into some more tuf and ssl issues next week. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #: #180
Description of the changes being introduced by the pull request: remove the
securesystemslib.util.TempFileclass.This was originally added to provide convenient handling of compressed and uncompressed file like objects however, those features of
securesystemslib.util.TempFileare no longer used by tuf nor in-toto.Furthermore
securesystemslib.util.TempFilehas some behavioural inconsistencies with a standard Python file object, which cause confusion for users of the class.The following code changes are introduced:
securesystemslib.util.persist_temp_file()to create a copy of the temporary file object (first arg) at the path specified in the second argument in 4a36f97securesystemslib.util.TempFileinsecuresystemslib.interfacein e594e66Please verify and check that the pull request fulfills the following
requirements: