Skip to content

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Nov 30, 2023

Adopt python-tuf's CI/CD GHA workflow to automatically release on GitHub and PyPI.

Along with this PR, I configured:

  • a GitHub "release" environment for this repo with protection rule (required review by 1 of: @jku, @adityasaky, @lukpueh)
  • a PyPI publisher trusted to release from cd.yml in this repo
  • GitHub branch protection rules, to use the new job names for "required checks"

Lukas Puehringer added 3 commits November 30, 2023 12:03
Moves all jobs from ci.yml to _test.yml and from where they are included
in ci.yml via the `uses` directive.

You can check that the jobs itself did not change by diffing the old
ci.yml with the new _test.yml:

```
diff \
 <(curl -s https://raw.githubusercontent.com/secure-systems-lab/securesystemslib/a3651a1b321b8ad05ddb6e85aaceb402acec9671/.github/workflows/ci.yml) \
 .github/workflows/_test.yml
```

Move jobs from ci.yml to _test.yml, so we can reuse them in different
workflows.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
- add build requirements file with pinned build dependency
- pin build backend in pyproject.yml (needs manual updating)

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Add GitHub workflow to build securesystemslib and release on GitHub and
PyPI. The workflow is copied from python-tuf with minimal changes, see:

```
diff \
  <(curl -s https://raw.githubusercontent.com/theupdateframework/python-tuf/c92cd28b38d3af5ee24411a3c2082fc2d6c37f4b/.github/workflows/cd.yml) \
  .github/workflows/cd.yml
```

Prerequisites and usage details are described at
https://github.com/theupdateframework/python-tuf/blob/v3.1.0/docs/RELEASE.md.
(a verify_release script does not exist for securesystemslib)

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh requested review from adityasaky and jku November 30, 2023 11:41
Copy link
Member

@adityasaky adityasaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lukpueh lukpueh merged commit f62f588 into secure-systems-lab:main Nov 30, 2023
@lukpueh
Copy link
Member Author

lukpueh commented Nov 30, 2023

Cheers! Let's try this out. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants