Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Make Scanner Images used Changeable via Helm Values#143

Closed
J12934 wants to merge 7 commits intomasterfrom
configure-scanner-images
Closed

Make Scanner Images used Changeable via Helm Values#143
J12934 wants to merge 7 commits intomasterfrom
configure-scanner-images

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Oct 14, 2020

  • Exposed all scanner images via the image.repository and image.tag helm value
  • Reordered the image config values to be at the top of the values file and the top of the README's, as these should generally be more important to the user as the parserImage configs.
  • Updated the appVersion style (with a v prefix to match the actual versions of the 3rd party images used. This lets us keep the ScanType helm templates consistent
  • For scanner images which are pinned using the digest / hash, these have been moved to the helm values to also be changeable by the user. I didnt want to put these into the appVersion as the digests are so long.

@J12934 J12934 self-assigned this Oct 14, 2020
@J12934
Copy link
Member Author

J12934 commented Oct 14, 2020

Will merge in the other repo ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant