This repository was archived by the owner on Apr 21, 2026. It is now read-only.
Conversation
added 10 commits
August 18, 2020 12:26
J12934
reviewed
Aug 27, 2020
Member
J12934
left a comment
There was a problem hiding this comment.
Ehm any idea what is going on here?
Also Build Warnings:
warn ESLintError:
/Users/jannikhollenbach/src/securecodebox.github.io/src/pages/getStarted/index.js
30:17 warning Emojis should be wrapped in <span>, have role="img", and have an accessible description
with aria-label or aria-labelledby jsx-a11y/accessible-emoji
✖ 1 problem (0 errors, 1 warning)
warn ESLintError:
/Users/jannikhollenbach/src/securecodebox.github.io/src/templates/doc.js
4:8 warning 'Sidebar' is defined but never used no-unused-vars
✖ 1 problem (0 errors, 1 warning)
Contributor
Author
|
The filter is intentional, since the bullet points are all nonsense and the whole design is still object of discussion I only wanted to represent the area where something could be, e.g. some quicklinks or contents of the documentation. If it is irritating I can remove this effect. |
added 2 commits
September 1, 2020 10:56
J12934
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

-> Loading images from low to high res instead of popping up when loaded
-> Reworked intro component to hold the image instead as background (image will be behind everything inside the intro)