Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

Feature/rework navigation#16

Merged
J12934 merged 14 commits intogh-sourcefrom
feature/rework-navigation
Sep 2, 2020
Merged

Feature/rework navigation#16
J12934 merged 14 commits intogh-sourcefrom
feature/rework-navigation

Conversation

@SirDany
Copy link
Copy Markdown
Contributor

@SirDany SirDany commented Aug 19, 2020

  • Updates navigation in menu
  • Adds overview page for documentation
  • Retrieves remote documentation, adds pages & links to them
  • Use gatsby-image instead of raw css
    -> Loading images from low to high res instead of popping up when loaded
    -> Reworked intro component to hold the image instead as background (image will be behind everything inside the intro)

@SirDany SirDany requested a review from J12934 August 19, 2020 15:40
@SirDany SirDany added the enhancement New feature or request label Aug 19, 2020
Copy link
Copy Markdown
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehm any idea what is going on here?

Kapture 2020-08-27 at 15 23 51

Also Build Warnings:

warn ESLintError:
/Users/jannikhollenbach/src/securecodebox.github.io/src/pages/getStarted/index.js
  30:17  warning  Emojis should be wrapped in <span>, have role="img", and have an accessible description
with aria-label or aria-labelledby  jsx-a11y/accessible-emoji

✖ 1 problem (0 errors, 1 warning)
warn ESLintError:
/Users/jannikhollenbach/src/securecodebox.github.io/src/templates/doc.js
  4:8  warning  'Sidebar' is defined but never used  no-unused-vars

✖ 1 problem (0 errors, 1 warning)

@SirDany
Copy link
Copy Markdown
Contributor Author

SirDany commented Aug 27, 2020

The filter is intentional, since the bullet points are all nonsense and the whole design is still object of discussion I only wanted to represent the area where something could be, e.g. some quicklinks or contents of the documentation. If it is irritating I can remove this effect.
Emojis is pretty obvious fixable, and the sidebar was a preperation for the layout, but can be removed, since it is not used atm.

@J12934 J12934 merged commit b977f6c into gh-source Sep 2, 2020
@Weltraumschaf Weltraumschaf deleted the feature/rework-navigation branch October 15, 2020 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants