Skip to content

chore: Rename flags #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 25, 2024
Merged

chore: Rename flags #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bde7d0
chore: rewrite some flag names
RKNF404 Dec 24, 2024
1c97f29
chore: rename JIT flag
RKNF404 Dec 24, 2024
ed50d2a
fix: dumb
RKNF404 Dec 24, 2024
bb131d4
fix: dumb part 2
RKNF404 Dec 24, 2024
98114cc
chore: adjust wording
RKNF404 Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions patches/disable-jit-for-internal-pages.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ index e5ce608907f72..09159a4e83115 100644
- if (!site_url.SchemeIsHTTPOrHTTPS())
+ // Disable JIT for non-web schemes.
+ if (!site_url.SchemeIsHTTPOrHTTPS()) {
+ if (base::FeatureList::IsEnabled(features::kDisableInternalPageJit))
+ if (!base::FeatureList::IsEnabled(features::kEnableInternalPageJit))
+ return true;
return false;
+ }
Expand All @@ -25,8 +25,8 @@ index 2d95d5e1df911..e7a29a6687a07 100644

namespace features {

+BASE_FEATURE(kDisableInternalPageJit, "DisableInternalPageJit",
+ base::FEATURE_ENABLED_BY_DEFAULT);
+BASE_FEATURE(kEnableInternalPageJit, "EnableInternalPageJit",
+ base::FEATURE_DISABLED_BY_DEFAULT);
+
// All features in alphabetical order.

Expand All @@ -48,7 +48,7 @@ index a69dcd3b24015..2f6f3d9265bbf 100644

namespace features {

+CONTENT_EXPORT BASE_DECLARE_FEATURE(kDisableInternalPageJit);
+CONTENT_EXPORT BASE_DECLARE_FEATURE(kEnableInternalPageJit);
+
// BEFORE MODIFYING THIS FILE: If your feature is only used inside content/, add
// your feature in `content/common/features.h` instead.
Expand Down
12 changes: 6 additions & 6 deletions patches/expose-flags.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ index 9d0181f447a1a..8e10017c678f9 100644
+ "Shows punycode for IDN domains to mitigate IDN homograph attacks. "
+ "Disabled by default. This feature is provided by hardened-chromium.",
+ kOsAll, FEATURE_VALUE_TYPE(url::kShowPunycodeDomains)},
+ {"disable-cross-origin-referrers", "Clear cross-origin referrers",
+ {"clear-cross-origin-referrers", "Clear cross-origin referrers",
+ "Clears referrers when navigating across origins. Disabled by default. "
+ "This feature is provided by hardened-chromium.", kOsAll,
+ FEATURE_VALUE_TYPE(net::features::kDisableCrossOriginReferrers)},
Expand All @@ -32,11 +32,11 @@ index 9d0181f447a1a..8e10017c678f9 100644
+ "Hides the profile icon in the toolbar in regular profiles. Enabled "
+ "by default. This feature is provided by hardened-chromium." , kOsAll,
+ FEATURE_VALUE_TYPE(features::kHideProfileIcon)},
+ {"disable-internal-page-jit", "Disable Internal Page Jit",
+ "Disable JIT for JavaScript and WASM on internal pages & extensions. "
+ "Enabled by default. This feature is provided by hardened-chromium.",
+ kOsAll, FEATURE_VALUE_TYPE(features::kDisableInternalPageJit)},
+ {"enable-gssapi", "Enable GSSAPI Authentication",
+ {"internal-page-jit", "Internal Page Jit",
+ "Toggle JIT for JavaScript and WASM on internal pages & extensions. "
+ "Disabled by default. This feature is provided by hardened-chromium.",
+ kOsAll, FEATURE_VALUE_TYPE(features::kEnableInternalPageJit)},
+ {"gssapi-support", "GSSAPI Authentication",
+ "Enables GSSAPI for authentication. WARNING! This can cause the "
+ "network service sandbox to become persistently disabled, enable only "
+ "if absolutely necessary. This switch is provided by hardened-chromium.",
Expand Down