Skip to content

chore: dont use bwrap if we don't have to #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025
Merged

chore: dont use bwrap if we don't have to #325

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee00641
chore: dont use bwrap if we don't have to
RKNF404 Jun 27, 2025
5ed3a21
Merge branch 'secureblue:live' into ld-preload-revamp
RKNF404 Jun 27, 2025
0bde514
chore: ignore codacy
RKNF404 Jun 27, 2025
9bf5e87
Merge branch 'live' into ld-preload-revamp
RKNF404 Jun 27, 2025
35097bb
Merge branch 'live' into ld-preload-revamp
RoyalOughtness Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions build/trivalent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# See the License for the specific language governing permissions and limitations under the License.

# Sanitize & protect risky variables
declare -rx LD_PRELOAD=""
declare -rx LD_LIBRARY_PATH=""
declare -rx LD_AUDIT=""
declare -rx LD_PROFILE=""
Expand Down Expand Up @@ -69,14 +68,20 @@ else
echo "A process is already open in this directory or Singleton process files are not present."
fi

BWRAP_ARGS="--dev-bind / /"
[[ -f "/etc/ld.so.preload" ]] && BWRAP_ARGS+=" --ro-bind /dev/null /etc/ld.so.preload"
# Do this at the end so that everything else still gets hardened_malloc
declare -rx LD_PRELOAD=""

# Sanitize std{in,out,err} because they'll be shared with untrusted child
# processes (http://crbug.com/376567).
exec < /dev/null
exec > >(exec cat)
exec 2> >(exec cat >&2)

# shellcheck disable=SC2086
exec bwrap $BWRAP_ARGS "$HERE/$CHROMIUM_NAME" $CHROMIUM_FLAGS "$@"
# If ld.so.preload is readable, it may be used to preload into the browser which we don't want
if [[ -r "/etc/ld.so.preload" ]]; then
# shellcheck disable=SC2086
exec bwrap --dev-bind / / --ro-bind-try /dev/null /etc/ld.so.preload "$HERE/$CHROMIUM_NAME" $CHROMIUM_FLAGS "$@"
else
# shellcheck disable=SC2086
exec -a "$0" "$HERE/$CHROMIUM_NAME" $CHROMIUM_FLAGS "$@"
fi