Skip to content

chore: add LOG_LEVEL to wrapper and conf #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2025
Merged

chore: add LOG_LEVEL to wrapper and conf #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd792da
chore(wrapper): make output logging configurable via env var
RKNF404 Nov 27, 2025
b9d45d6
chore(wrapper): set default properly for LOG_LEVEL
RKNF404 Nov 27, 2025
a4e2b95
chore(conf): add verbose logging for chromium to LOG_LEVEL
RKNF404 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/trivalent.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,6 @@ if [ "$ARCH" == "x86_64" ] ; then
fi
fi

[ "$LOG_LEVEL" >= 2 ] && CHROMIUM_SYSTEM_FLAGS+=" --enable-logging=stderr --v=1"

[ -n "$FEATURES" ] && CHROMIUM_SYSTEM_FLAGS+=" --enable-features=$FEATURES"
8 changes: 6 additions & 2 deletions build/trivalent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ declare -rx CHROME_WRAPPER
HERE="${CHROME_WRAPPER%/*}"
declare -r HERE

# LOG_LEVEL=[0,1,2]
# Default: 0
declare -ix LOG_LEVEL="${LOG_LEVEL:0}"

declare FEATURES
declare CHROMIUM_FLAGS

Expand Down Expand Up @@ -75,10 +79,10 @@ IS_BROWSER_RUNNING=$?

# Fix Singleton process locking if the browser isn't running and the singleton files are present
if [[ $IS_BROWSER_RUNNING -eq 1 ]] && compgen -G "$HOME/.config/$CHROMIUM_NAME/Singleton*" > /dev/null; then
echo "Ruh roh! This shouldn't be here..."
[[ "$LOG_LEVEL" > 0 ]] && echo "Ruh roh! This shouldn't be here..."
rm "$HOME/.config/$CHROMIUM_NAME/Singleton"*
else
echo "A process is already open in this directory or Singleton process files are not present."
[[ "$LOG_LEVEL" > 0 ]] && echo "A process is already open in this directory or Singleton process files are not present."
fi

# Do this at the end so that everything else still gets hardened_malloc
Expand Down