fix: Temporary work around for build error #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
we added it as a flag due to potential breakage. this would negate that |
Contributor
|
if anything we should probably drop the patch, build, and then fix it after we get the patch release out |
Collaborator
Author
|
Yeah, will do a proper fix when I get the time, it was 2 am when I saw the issue. Dropping the patch for now is a decent idea though to get a a build out. |
Collaborator
Author
|
@qoijjj Turns out, that change would have done nothing to prevent gssapi from working, the initial value seems completely ignored and replaced by the prefs value which is part of the patch already. |
RoyalOughtness
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue relating to C code in a mojo file without the proper inclusion. This is just temporary to pass the build.