Skip to content

fix: Temporary work around for build error #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: Temporary work around for build error #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
498a20e
Temporary work around for build error
RKNF404 Oct 2, 2024
108f7d3
Remove redundancy
RKNF404 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions patches/disable-gssapi-to-enable-network-service-sandbox.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,3 @@ index 249ff5ecffa8d..c9c36e3226290 100644
}
#endif // BUILDFLAG(IS_LINUX)

diff --git a/services/network/public/mojom/network_service.mojom b/services/network/public/mojom/network_service.mojom
index 3f3dac717be42..29a9946052308 100644
--- a/services/network/public/mojom/network_service.mojom
+++ b/services/network/public/mojom/network_service.mojom
@@ -95,7 +95,11 @@ struct HttpAuthDynamicParams {

// Indicates whether the GSSAPI library should be loaded. Only supported on
// Chrome OS and Linux.
- bool allow_gssapi_library_load = true;
+ // GSSAPI will disable the Network Service Sandbox when websites try to load
+ // it, not desirable from a security perspective.
+ bool allow_gssapi_library_load = base::CommandLine::
+ ForCurrentProcess()->HasSwitch(
+ "enable-gssapi"));

// True if Basic authentication challenges should be allowed for non-secure
// HTTP responses.