Skip to content

Conversation

@RoyalOughtness
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ShadowSlayer1441 ShadowSlayer1441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

One note is that rather oddly whenever you are viewing a page other than the main https://royaloughtness.github.io/ like https://royaloughtness.github.io/code-of-conduct the icon in the top left becomes greyscale. Happens both on hardened chromium on secureblue and vanadium on GOS.

@RoyalOughtness
Copy link
Contributor Author

other notes to myself:

  • Contributing page shouldn't say "welcome to secureblue"
  • install page needs a title

@EsseLowNitro
Copy link
Collaborator

@ShadowSlayer1441

[...] the icon in the top left becomes greyscale.

Intentional and unrelated to this specific PR, https://grapheneos.org does the same. Their icon is monochrome and the effect is to actually apply a blue accent to the page you're currently on in its own header listing, but I imagined it would be nice if the effect applied in a logo that's already very blue was what you saw instead.

@ShadowSlayer1441
Copy link
Collaborator

ShadowSlayer1441 commented Jan 2, 2025

Sooraj's link mentions it, but links should probably be underlined or include a link icon in addition to being a different color for accessibility.

@EsseLowNitro
Copy link
Collaborator

EsseLowNitro commented Jan 2, 2025

[...] links should probably be underlined in addition to being a different color for accessibility.

They are only not underlined in mobile, since the CSS underlines links on hover and click, of which only click really exists on mobile (with a touchscreen only, which is most cases).

In any case, I think investigating this is in scope for a separate future PR resolving issue #8

@RoyalOughtness RoyalOughtness merged commit 78063a6 into secureblue:live Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants