-
-
Notifications
You must be signed in to change notification settings - Fork 26
feat: new articles and reorganization #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
One note is that rather oddly whenever you are viewing a page other than the main https://royaloughtness.github.io/ like https://royaloughtness.github.io/code-of-conduct the icon in the top left becomes greyscale. Happens both on hardened chromium on secureblue and vanadium on GOS.
|
other notes to myself:
|
Intentional and unrelated to this specific PR, https://grapheneos.org does the same. Their icon is monochrome and the effect is to actually apply a blue accent to the page you're currently on in its own header listing, but I imagined it would be nice if the effect applied in a logo that's already very blue was what you saw instead. |
|
Sooraj's link mentions it, but links should probably be underlined or include a link icon in addition to being a different color for accessibility. |
They are only not underlined in mobile, since the CSS underlines links on hover and click, of which only click really exists on mobile (with a touchscreen only, which is most cases). In any case, I think investigating this is in scope for a separate future PR resolving issue #8 |
No description provided.