feat(selinux): Remove multiple permissions from trivalent_domain, reducing attack surface#2015
Merged
HastD merged 6 commits intosecureblue:livefrom Mar 10, 2026
Merged
Conversation
`dyntransition` does not seem to be needed by trivalent: - chromium does not make use of `setcon` at the moment - it would probably need `setcurrent` first - if it actually needed dyntransition, it should use `dyntrans_pattern`
By-default trivalent makes use of chromium's user namespaces sandbox instead of using the older SUID sandbox, thus capabilities outside of user namespaces are not be needed and should be removed
Remove net_admin and setpcap userns caps. They are not present in the refpolicy. Some shallow tests to run trivalent without them did not show any negative consequences nor show up in logs.
PhysicsIsAwesome
changed the title
Collaborator
|
@PhysicsIsAwesome can you document what tests you ran on this? |
Contributor
Author
Ran Trivalent, visited a few websites, ran keepassxc extension and tested connection to the keepassxc app. Checked logs for Selinux denials. Although I don't see a theoretical need for the permissions I removed, some additional testing from other users might still be helpful, just to be sure to not oversee some edge case. |
WavyEbuilder
reviewed
Mar 8, 2026
Collaborator
WavyEbuilder
left a comment
WavyEbuilder
left a comment
There was a problem hiding this comment.
I can indeed speak positively on removing transition and dyntransition, that seems expected and reasonable to me and is in life with what I have policy wise.
HastD
approved these changes
Mar 8, 2026
RoyalOughtness
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove multiple permissions from trivalent_domain, including: