Skip to content

Conversation

@Deathsteps
Copy link
Contributor

Fix the following issue:

The hotLevel column of the data is a column of number type, and many records will contains a zero value. The origin code will treat number zero as undefined and return the empty string.

         <ExcelFile>
            <ExcelSheet data={this.props.data} name="list">
              <ExcelColumn label="ID" value="id" />
              <ExcelColumn label="hotelName" value="name" />
              <ExcelColumn label="hotLevel" value="hotLevel" />
            </ExcelSheet>
          </ExcelFile>

@securedeveloper securedeveloper self-requested a review March 28, 2018 19:48
Copy link
Owner

@securedeveloper securedeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@securedeveloper securedeveloper merged commit d58858f into securedeveloper:master Mar 28, 2018
@securedeveloper
Copy link
Owner

@Deathsteps Thank you for your code, I'm changing library to use Typescript and webpack, we will have better code and performance in coming weeks.

@Deathsteps Deathsteps deleted the number-zero-row-value branch March 29, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants