Skip to content

Added OOBE for MAUI#91

Merged
d2dyno1 merged 17 commits intomasterfrom
f_oobe
Aug 31, 2025
Merged

Added OOBE for MAUI#91
d2dyno1 merged 17 commits intomasterfrom
f_oobe

Conversation

@d2dyno1
Copy link
Copy Markdown
Member

@d2dyno1 d2dyno1 commented Aug 21, 2025

No description provided.

@d2dyno1 d2dyno1 requested a review from Copilot August 26, 2025 15:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive Out-of-Box Experience (OOBE) for the MAUI platform with iOS biometric authentication support and various improvements across the codebase.

  • Implements complete iOS biometric authentication using Face ID/Touch ID
  • Adds a new introduction/onboarding screen for MAUI with multi-slide gallery interface
  • Refactors method names from "NoThrow" to "NoFailure" and authentication method names for consistency
  • Updates settings property from "IsIntroduced" to "WasIntroduced" for OOBE tracking

Reviewed Changes

Copilot reviewed 76 out of 91 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
SafetyHelpers.cs Renames all "NoThrow" methods to "NoFailure" for consistency
IAuthenticator.cs Renames CreateAsync/SignAsync to EnrollAsync/AcquireAsync with improved documentation
AuthenticationExtensions.cs Updates to use renamed authenticator methods
MainViewModel.cs Removes commented OOBE code
VaultProtectedKeyDataModel.cs Adds new data model for protected key storage
IntroductionPage.xaml/cs Implements new MAUI introduction screen with gallery navigation
IOSBiometricViewModel.cs Adds iOS biometric authentication using Secure Enclave
Various MAUI files Updates UI templates, styles, and resources for iOS support
Comments suppressed due to low confidence (2)

src/Platforms/SecureFolderFS.Maui/Views/IntroductionPage.xaml.cs:1

  • No bounds checking before decrementing _currentIndex. This could result in negative indices or accessing non-existent slide resources, potentially causing runtime exceptions.
using SecureFolderFS.Maui.Helpers;

src/Platforms/SecureFolderFS.Maui/Views/IntroductionPage.xaml.cs:1

  • No bounds checking before incrementing _currentIndex. This could result in accessing slide resources beyond the available range, potentially causing runtime exceptions.
using SecureFolderFS.Maui.Helpers;

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/Platforms/SecureFolderFS.Maui/Views/MainPage.xaml.cs Outdated
Comment thread src/Platforms/SecureFolderFS.Maui/Views/MainPage.xaml.cs Outdated
Comment thread src/Platforms/SecureFolderFS.Maui/UserControls/IntroductionSlide.xaml.cs Outdated
@d2dyno1 d2dyno1 added the approved The pull request has been reviewed and approved label Aug 31, 2025
@d2dyno1 d2dyno1 marked this pull request as ready for review August 31, 2025 16:01
@d2dyno1 d2dyno1 merged commit ddd071d into master Aug 31, 2025
@d2dyno1 d2dyno1 deleted the f_oobe branch August 31, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved The pull request has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants