Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
===========================================
+ Coverage 92.33% 100.00% +7.66%
===========================================
Files 46 1 -45
Lines 913 13 -900
===========================================
- Hits 843 13 -830
+ Misses 70 0 -70 Continue to review full report at Codecov.
|
| @api_manager = ApiManager.new(@event_manager, @options) | ||
| SecureNativeLogger.init_logger(@options.log_level) | ||
| end | ||
| class SecureNativeSDK |
There was a problem hiding this comment.
Since it's unique (no other class is under the name SecureNativeSDK using a module will be redundant --> SecureNative::SecureNativeSDK
| spec.version = '0.1.29' | ||
| spec.authors = ['SecureNative'] | ||
| spec.email = ['support@securenative.com'] | ||
|
|
There was a problem hiding this comment.
You need to define spec. test_files = Dir['spec//*']
And regarding spec.files, do u really need this Dir.chdir(File.expand_path('..', FILE)) ?
why not something like this spec.files = Dir['{lib}//*'] + ['README.md']
There was a problem hiding this comment.
I've added spec. test_files, spec folder also contains a spec help file which defines tests.
This file was autogenerated by IntelliJ, I guess it's they're way of specifying files (using git), anyway i don't know if using spec.files = Dir['{lib}//*'] + ['README.md'] will do it, still missing important files like Gemfile and securenative.spec not sure it will work bundles like that
3 participants
No description provided.