Skip to content

ci: merge coverage upload into main workflow and remove duplicate#234

Open
kdacosta0 wants to merge 1 commit into
mainfrom
SECURESIGN-4443
Open

ci: merge coverage upload into main workflow and remove duplicate#234
kdacosta0 wants to merge 1 commit into
mainfrom
SECURESIGN-4443

Conversation

@kdacosta0
Copy link
Copy Markdown
Member

@kdacosta0 kdacosta0 commented May 15, 2026

Summary

  • Deleted standalone code-coverage.yml workflow that duplicated unit test runs just to upload coverage
  • Added unit-test-coverage Makefile target that runs tests with -coverprofile
  • Updated main.yml to use the new target and upload coverage to Codecov via OIDC
  • Standardized the coverage flag to unit and simplified codecov.yml with default_rules

Test plan

  • Verify unit tests still pass in the main workflow
  • Verify Codecov receives uploads with the unit flag
  • Confirm only one workflow runs tests (no duplicate runs)

🤖 Generated with Claude Code

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.33%. Comparing base (d7f10cf) to head (90f3bf5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   18.33%   18.33%           
=======================================
  Files           3        3           
  Lines          60       60           
=======================================
  Hits           11       11           
  Misses         49       49           
Flag Coverage Δ
unit 18.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdacosta0 kdacosta0 marked this pull request as draft May 15, 2026 15:00
@kdacosta0 kdacosta0 changed the title ci: standardize coverage flag to 'unit' and simplify codecov.yml ci: merge coverage upload into main workflow and remove duplicate May 18, 2026
Delete the standalone code-coverage.yml workflow that re-ran unit tests
just to upload coverage. Instead, add a unit-test-coverage Makefile
target and use it in main.yml alongside the Codecov upload step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kdacosta0 kdacosta0 marked this pull request as ready for review May 18, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants