Skip to content

Chore: weekly repo cleanup#497

Merged
mattaereal merged 5 commits into
developfrom
chore/weekly-cleanup
May 25, 2026
Merged

Chore: weekly repo cleanup#497
mattaereal merged 5 commits into
developfrom
chore/weekly-cleanup

Conversation

@scode2277
Copy link
Copy Markdown
Collaborator

In thi PR:

  • fixed 'mdxTextExpression' build errors (triggered by 'Revision' heading in the certs files): fixed by moving the heading right after the description
  • fixed broken SEAL Code of Conduct link
  • fixed mermaid dark mode visibility
  • simplified post-build scripts console logs: removed too verbose console logs
  • added guidance for too long files to contribution docs
  • cleaned up numbered heading in awareness fw
  • fixed linter outputs
  • fixed spellchecker outputs
  • synced badges
  • synced tags
  • synced indexes

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • Describe your changes, substitute this text with the information
  • If you are touching an existing piece of content, tag current contributors from the attribution list
  • If there is a steward for that framework, ask the steward to review it
  • If you're modifying the general outline, make sure to update it in the vocs.config.ts adding the dev: true parameter
  • If you need feedback for your content from the wider community, share the PR in our Discord
  • Review changes to ensure there are no typos; see instructions below.

scode2277 added 5 commits May 6, 2026 19:12
- fixed linter outputs
- fixed spellchecker outputs
- synced badges
- synced tags
- synced indexes
- fixed mdxTextExpression build warnings
- fixed broken SEAL CoC link
- fixed mermaid dark mode visibility
- simplified post-build scripts console logs
- added guidance for too long files to contribution docs
- cleaned up numbered heading in awareness fw
- fixed linter outputs
- fixed spellchecker outputs
- synced badges
- synced tags
- synced indexes
@scode2277 scode2277 self-assigned this May 15, 2026
Copy link
Copy Markdown
Collaborator

@frameworks-volunteer frameworks-volunteer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: z-ai/glm-5.1 Reasoning: medium Provider: openrouter

Reviewed PR #497 (Chore: weekly repo cleanup). 26 files changed vs develop.

Security Review -- PASS

  • No hardcoded secrets, tokens, or API keys
  • innerHTML usage in MermaidRenderer is pre-existing (mermaid SVG + error message interpolation); no new vectors introduced
  • MutationObserver re-renders on theme toggle only; same code prop, no injection risk
  • No suspicious dependencies, no eval, no unsafe deserialization

QA Review -- PASS (minor notes)

  • CoC link updated to https://radar.securityalliance.org/code_of_conduct/ -- verified 200 OK
  • Awareness pages: numbered headings (1., 2.1., 3.4.1.) stripped to plain headings -- cleaner, correct
  • Cert pages: revision line moved after intro paragraph -- consistent reorder, no content change
  • MermaidRenderer: dark mode via document.documentElement.classList.contains("dark") + MutationObserver; unique render ID via renderCount.current prevents ID collisions -- good pattern
  • Generator scripts: verbose per-file console.logs removed, summary only -- cleaner build output
  • network-security.mdx: line-length formatting only (no content changes), markdown table alignment
  • contributors.json: badge sync (active/dormant updates), new tansawit entry -- correct structure
  • wordlist.txt: HSTS added -- appropriate given network-security references
  • Template: <framework-folder> -> {framework-folder} -- clearer placeholder syntax
  • VPNs casing fix: Vpns -> VPNs with ACRONYM_MAP in generator -- good fix

Minor note: commits fe42015 and af70135 add then remove target="_blank" on CoC link -- revert-in-place. Not harmful but slightly messy history. Consider squashing before merge if desired.

Verdict: Approve -- all changes are routine cleanup, linter/spellcheck sync, and incremental improvements. No security or quality concerns.

@mattaereal mattaereal merged commit 287ff7e into develop May 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants