adding the functionality for fixed and reversible jump #24
Merged
bvandekerkhof merged 95 commits intosede-open:mainfrom Jun 24, 2025
Merged
adding the functionality for fixed and reversible jump #24bvandekerkhof merged 95 commits intosede-open:mainfrom
bvandekerkhof merged 95 commits intosede-open:mainfrom
Conversation
Updating to latest code
This reverts commit fe3a20c.
…ap and updating documentation.
…lise function to extract relevant properties from source_fixed and use the mapping instead of hardcoded strings.
…le notebook with the fixed/reversible sources.
mattj89
reviewed
Mar 7, 2025
Collaborator
mattj89
left a comment
mattj89
left a comment
There was a problem hiding this comment.
The approach looks good- many thanks for doing the implementation. I think you could maybe simplify the defaults in model, and a couple of other minor comments on the rest of the code. I think that we probably need to sort out the plotting in the example notebook (or possibly in general) before we offer this as an example in the main code base- will chat to you about this separately.
mattj89
reviewed
Mar 7, 2025
Collaborator
mattj89
left a comment
mattj89
left a comment
There was a problem hiding this comment.
One extra comment about code formatting.
…the plotting of true locations as the Scattermapbox is depreceted.
…in the plotting functionality
…model and emission rates for the source instead of the EQL model
… source locations instead of EQL model
Contributor
Author
|
The original example in the repo works now with the proposed changes. |
…d add the location of the fixed sources as the scatter plot instead of changing the indices of the summary_results
…e new added cases
Signed-off-by: code_reformat <>
Signed-off-by: TannazH <111283363+TannazH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is for adding a new feature to pyELQ enabling the use of fixed sources and reversible jump simultaneously.
With this functionality a use can provide a list of location for the fixed sources in which the emission rate will be estimated for them and their location is assumed to be fixed. The reversible jump functionality explores the area for remaining potential emission sources.
For the implementation we create "ParameterMapping" class to map the map the variables or parameterized labels needed for creating the mcmc. Therefore, the "map" dictionary is dynamic and its values can be changed by appending a string to the default "map". All the hard coded keys in the "source.py" and "source_model.py" are replaced by the keys in the mapping dictionary. The ELQModel is also changed to accept a "fixed_source_model" (with its default being set to None)
Type of change
Please delete options that are not relevant.
Jupyter Notebooks
I made a new Jupyter notebook (example_fixed_RJ) to setup and run pyELQ for fixed and reversible jump.
How Has This Been Tested?
I can add test if you think it is necessary
Checklist: