script_debug: expose SigVersion in callback#145
script_debug: expose SigVersion in callback#145sedited merged 1 commit intosedited:feature_script_debugfrom
Conversation
febyeji
force-pushed
the
script-debug/sigversion
branch
from
4a6d93b to
24b9e8f
Compare
sedited
left a comment
sedited
left a comment
There was a problem hiding this comment.
lgtm, just needs to fix from its parent PR.
|
Needs a rebase :) |
febyeji
force-pushed
the
script-debug/sigversion
branch
from
24b9e8f to
7b3da27
Compare
sedited
left a comment
sedited
left a comment
There was a problem hiding this comment.
LGTM
Sorry for taking this long to get around to looking at this again. I'll also be away for the next few weeks. I'd still be very interested in a more interactive implementation of the debugger. Something where can developers can provide and edit op codes and push data on the fly, provide transactions, or just singular script fragments. and interactively step through execution like a normal debugger.
|
@sedited Thank you for the reviews! I'll work on designing the interfaces for the interactive debuggers. I will look into the features that you mentioned. (editable opcodes, push data, step-through execution etc.) Will open follow-up PRs. Enjoy your time off! |
2 participants
Summary
SigVersion(BASE/WITNESS_V0/TAPROOT/TAPSCRIPT) in the debug callbackSigVersionenum to Rust bindings withTryFrom<u8>Tests
test_script_debug: assertsSigVersion::Basefor P2PKH framesDepends on #143 and #144.