feat(core): expose BlockTreeEntry::ancestor#164
Merged
alexanderwiederin merged 1 commit intoApr 29, 2026
Merged
Conversation
alexanderwiederin
requested changes
Apr 25, 2026
Collaborator
alexanderwiederin
left a comment
alexanderwiederin
left a comment
There was a problem hiding this comment.
Cool! Let's get #166 in first and you can develop against the pulled in C API. No need to make the changes manually.
Owner
|
Needs a rebase now :) |
pzafonte
force-pushed
the
expose-block-tree-entry-get-ancestor
branch
from
78ec3f8 to
9513a36
Compare
Contributor
Author
|
Ah! Was unaware of the process involved in updating the C API, good to know moving forward. I rebased, and added respective test cases in the latest commit. |
alexanderwiederin
requested changes
Apr 28, 2026
Collaborator
alexanderwiederin
left a comment
alexanderwiederin
left a comment
There was a problem hiding this comment.
Small suggestion to improve the docs and I think we are good to go!
Collaborator
|
Also, please make an entry to CHANGELOG.md |
Exposes btck_block_tree_entry_get_ancestor as BlockTreeEntry::ancestor in the Rust bindings. Returns Option<BlockTreeEntry> and guards against height < 0 or height > self.height() before calling into the C API.
pzafonte
force-pushed
the
expose-block-tree-entry-get-ancestor
branch
from
9513a36 to
bb6fd30
Compare
Contributor
Author
|
Updated the doc and changelog in bb6fd30 |
Collaborator
|
Looks good - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes btck_block_tree_entry_get_ancestor as BlockTreeEntry::ancestor in the Rust bindings. Returns Option and guards against height < 0 or height > self.height() before calling into the C API.
Closes #162.