refactor: 🚚 rename target and location to jsonpath
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
commented
Oct 1, 2025
martonvago
requested changes
Oct 1, 2025
Contributor
martonvago
left a comment
martonvago
left a comment
There was a problem hiding this comment.
Nice, just very minor comments!
The 2 cons I can think of about calling it field:
- Doesn't express clearly that it has to be in JSON path notation
- One JSON path can correspond to multiple fields (e.g. you can target the
nameof all resources or all properties of a particular resource). Maybe this is not captured by justfield?
docs/guide/config.qmd
Outdated
| express the location of the field or fields in [JSON | ||
| path](https://en.wikipedia.org/wiki/JSONPath) notation and define an | ||
| `Exclude` object with this `target`. For example, you can exclude all | ||
| `Exclude` object with the `jsonpath`. For example, you can exclude all |
Contributor
There was a problem hiding this comment.
Suggested change
| `Exclude` object with the `jsonpath`. For example, you can exclude all | |
| `Exclude` object with this `jsonpath`. For example, you can exclude all |
This sounds better to me, but 🤷
Member
Author
There was a problem hiding this comment.
I've rewritten the sentence a bit now. Let me know what you think.
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
signekb
commented
Oct 1, 2025
It's used now, so doesn't need to be included here.
lwjohnst86
approved these changes
Oct 1, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
🎉 Nice! I'll update my PR after merging this 😁
1 task
lwjohnst86
pushed a commit
that referenced
this pull request
Oct 6, 2025
# Description Based on a comment in #89 that this needs to be updated. Needs a quick review. ## Checklist - [X] Ran `just run-all`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #88
Needs an in-depth review.
Afterthought: Could we call "jsonpath" "field" instead to make it even simpler? Bc it's a JSON path to a specific field?
Checklist
just run-all