feat: ✨ add exclusion by jsonpath
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Any reason for not using https://jg-rp.github.io/python-jsonpath/ to handle JSON paths? That should be able to handle JSON path selectors like wildcards, plus much more. (Some notes about this on issues #55 and #56 -- may or may not be useful |
Member
Author
|
@martonvago I just noticed that after making this! Yea, I'll check into that and revise this PR to use it 😁 |
Member
Author
|
@martonvago done! Some JSONPath queries don't work (see tests) and I'm not sure why. |
Member
Author
|
|
…package into feat/add-target-exclusion
lwjohnst86
commented
Oct 1, 2025
lwjohnst86
changed the title
jsonpath
martonvago
requested changes
Oct 10, 2025
Contributor
martonvago
left a comment
martonvago
left a comment
There was a problem hiding this comment.
Very nice, looking great!! ⭐
Just some minor comments
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com> Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
…package into feat/add-target-exclusion
martonvago
requested changes
Oct 14, 2025
Contributor
martonvago
left a comment
martonvago
left a comment
There was a problem hiding this comment.
Just a small thing, otherwise great!
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
github-project-automation
bot
moved this from In Progress
to Done
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exclude by jsonpath, as well as implement AND logic for type and jsonpath.
I switched to using
Optionaltyping.Closes #56, closes #75, closes #102
Needs an in-depth review.
Checklist
just run-all