refactor: ♻️ convert to using updated template data package #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
commented
Aug 28, 2025
signekb
commented
Aug 28, 2025
| "roles": [ | ||
| "creator" | ||
| "creator", | ||
| "author" |
Member
Author
There was a problem hiding this comment.
Added this bc it's the description of this person in the data's README.txt
signekb
commented
Aug 28, 2025
lwjohnst86
requested changes
Sep 1, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nice! Only very minor suggestions.
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
lwjohnst86
deleted the
refactor/convert-to-using-updated-template-data-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the repo to use the updated
template-data-package. It also starts the process of using the*_properties.pyscripts inmain.py.For this PR, I've followed the Sprout Creating a Data Package guide and updated the package properties and
datapackage.jsonandREADME.mdby uncommenting those steps inmain.py.I'll do a separate PR that adds the data resources and updates the preprocessing scripts.
Closes #23
This PR needs an in-depth review.
Checklist
just run-all(fails bc some comment lines are too long inscripts/download-data.pyandscripts/convert-meta.py, will fix in a separate PR adding the data resources)