Skip to content

fix: 🐛 change fields_match to be an array in extract_resource_properties() #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025
Merged

fix: 🐛 change fields_match to be an array in extract_resource_properties() #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79466fd
fix: :bug: change `fields_match` to be an array in `extract_resource_…
signekb Jun 12, 2025
a625cec
test: :white_check_mark: update test with array in `fields_match` to …
signekb Jun 12, 2025
249a90c
Merge branch 'main' into fix/change-fieldsmatch-to-be-an-array-in-ext…
signekb Jun 12, 2025
5c8065b
Merge branch 'main' into fix/change-fieldsmatch-to-be-an-array-in-ext…
signekb Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/seedcase_sprout/extract_resource_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ def extract_resource_properties(data: pl.DataFrame) -> ResourceProperties:

resource_properties = ResourceProperties()
resource_properties.type = "table"
resource_properties.schema = TableSchemaProperties(fields_match="equal")
# The fields_match property is supposed to be a string, but there's an error in the
# JSON schema. This should be fixed in datapackage V2.1.
resource_properties.schema = TableSchemaProperties(fields_match=["equal"])
resource_properties.schema.fields = _extract_field_properties(data)

return resource_properties
Expand Down
2 changes: 1 addition & 1 deletion tests/test_extract_resource_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def _keep_extractable_properties(
)

return ResourceProperties(
schema=TableSchemaProperties(fields=fields, fields_match="equal"),
schema=TableSchemaProperties(fields=fields, fields_match=["equal"]),
type="table",
)

Expand Down