refactor: ♻️ move copier test to own file #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Aug 25, 2025
| git commit --quiet -m "test: preparing to copy onto an existing package" && | ||
| copy $template_dir $test_dir $commit #&& | ||
| # Checks and builds ----- | ||
| # just run-all |
Contributor
Author
There was a problem hiding this comment.
Not sure if we want to run all recipes?
- Many checks/tests need dependencies installed (so can't skip tasks)
- Test coverage will fail (because the repo is empty) and fail the whole test. Maybe there's a way of ignoring this?
Member
There was a problem hiding this comment.
Yea, I think I agree. Plus it will install a bunch of stuff on the workflow CI that isn't really necessary.
3 tasks
lwjohnst86
approved these changes
Aug 26, 2025
| git commit --quiet -m "test: preparing to copy onto an existing package" && | ||
| copy $template_dir $test_dir $commit #&& | ||
| # Checks and builds ----- | ||
| # just run-all |
Member
There was a problem hiding this comment.
Yea, I think I agree. Plus it will install a bunch of stuff on the workflow CI that isn't really necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the copier test to its own file. Moved from #140 .
This PR needs a quick review.
Checklist
just run-all-- won't run until other PRs merged in