refactor: ♻️ revise so github_repo is name of folder
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebsite into refactor/check-that-abbrev-has-no-spaces
lwjohnst86
changed the title
github_repo is name of folder
martonvago
requested changes
Aug 8, 2025
Contributor
martonvago
left a comment
martonvago
left a comment
There was a problem hiding this comment.
Nice, just minor comments ⭐
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
lwjohnst86
commented
Aug 8, 2025
martonvago
approved these changes
Aug 8, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed the use of
website_abbrev(it was only used once anyway). Also found a bug. We need to userealpathfordst_pathotherwise it will use.if the template destination path is the same as the working directory. I also split it so thegithub_repowas determined fromdst_path(which requires use of therealpathfirst).Closes #20
This PR needs an in-depth review.
Checklist
just run-all