Skip to content

Conversation

@lwjohnst86
Copy link
Member

Description

Revise the get contributors file to output text and redirect to the repos includes/ folder. Originally it wasn't meant to be kept in the repo (ignored by Git), but since the build is a bit weird with it included, this resolves that by keeping it as a committed file.

This PR needs a quick review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner September 4, 2025 11:48
@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Iteration planning Sep 4, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌 A couple of suggestions:

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Sep 4, 2025
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from signekb September 4, 2025 13:56
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Sep 4, 2025
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from signekb September 4, 2025 14:27
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Sep 4, 2025
lwjohnst86 and others added 3 commits September 5, 2025 10:22
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from signekb September 5, 2025 08:25
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Sep 5, 2025
@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Sep 5, 2025
@signekb signekb merged commit 1725d09 into main Sep 5, 2025
5 checks passed
@signekb signekb deleted the refactor/move-contributors-into-includes branch September 5, 2025 13:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in Iteration planning Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants