Adds @RequiresCRUD security annotation && Interceptors #238
Conversation
|
Can you show a simple example of how to use this annotation ? I'm somewhat understanding its purpose from the test, but an explanation would help :) |
Sherpard
changed the title
| import org.seedstack.seed.security.spi.CRUDActionResolver; | ||
|
|
||
| public class TestActionResolver implements CRUDActionResolver { | ||
|
|
There was a problem hiding this comment.
I'd name the Class CrudActionResolver in order to be compliant to java standard name with acronyms and also to be flat with CrudSecurityIT.
I also would rename CRUDAction to CrudAction for the same reasons.
There was a problem hiding this comment.
Agree. I suggested those names but it's better to keep CamelCase even for acryonyms.
There was a problem hiding this comment.
Agree, already commited the cangue :)
|
The canResolve method is not useful because resolve already returns an Optional and can return empty if nothing is detected. I removed it and refactored the implementation of the interceptors a bit in my fork at https://github.com/adrienlauer/seed/tree/feature/RequiresRestAnnotation. |
Added AbstractInterceptor as a base class for the interceptors, as much of their logic were pretty much the same Added SPI functionality to define custom verb resolvers Implementation improvements on CRUD security Simplify CrudActionResolver
Sherpard
force-pushed
the
feature/RequiresRestAnnotation
branch
from
e4d3433 to
6d6464c
Compare
Added AbstractInterceptor as a base class for the interceptors, as much of their logic were pretty much the same Added SPI functionality to define custom verb resolvers Implementation improvements on CRUD security Simplify CrudActionResolver
4 participants
Smart Annotation that takes care of adding a permission check,
User is able to configure how to resolve the CRUD verb implementing
CRUDActionResolveron their code