Fix: invalid Cache-Control directives for REST package #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. There was a typo on the `must-revalidate` directive (missing dash) 2. The `Cache-Control` header didn't completely prevent HTTP caching 3. The `Last-Modified` header is advantageously replaced by right `Expires` and `Cache-Control` headers
helix
force-pushed
the
fix/rest-http-cache
branch
from
ca8223a to
a1a15bb
Compare
Sherpard
reviewed
Aug 22, 2018
| switch (this.policy) { | ||
| case NO_CACHE: | ||
| MultivaluedMap<String, Object> headers = responseContext.getHeaders(); | ||
| headers.putSingle(HttpHeaders.LAST_MODIFIED, new Date()); |
Member
There was a problem hiding this comment.
Removing this header was intended?
Member
There was a problem hiding this comment.
I think this is intentional because this header is only making sense when you want to actually cache the resource.
Member
|
After reading the provided links (SO and RFC), I agree this is the right way to do it. |
Merged
Contributor
Author
|
@adrienlauer woops, indeed I forgot to update the tests... my bad. Thanks for the merge though! PS: sorry for the late response, I didn't receive any email notifications from GitHub... weird |
hervestern
pushed a commit
to hervestern/seed
that referenced
this pull request
Aug 10, 2020
Also removes useless DependencyProvider SPI (for optional dependencies which are now handled directly). Also improves instantiation of the EL ExpressionFactory. Also makes the validation message interpolator automatically adapt to whether the runtime environment supports EL or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must-revalidatedirective (missing dash)Cache-Controlheader didn't completely prevent HTTP cachingLast-Modifiedheader is advantageously replaced by rightExpiresandCache-Controlheaders