TheMovieDB Api key hardcoded - Bad Practice?

[Patrick2052]

seerr/server/api/themoviedb/index.ts

Line 138 in ff88d52

api_key: '431a8708161bcd1f1fbe7536137e61ed',

While browsing the code i noticed that there is a hardcoded api key for themoviedb in server/api/themoviedb/index.ts. Does anyone know if there is a reason for this? It seems risky with a shared key to hit rate limits on the service.

Code (server/api/themoviedb/index.ts):

class TheMovieDb extends ExternalAPI implements TvShowProvider {
  private locale: string;
  private discoverRegion?: string;
  private originalLanguage?: string;
  constructor({
    discoverRegion,
    originalLanguage,
  }: { discoverRegion?: string; originalLanguage?: string } = {}) {
    super(
      'https://api.themoviedb.org/3',
      {
        api_key: '431a8708161bcd1f1fbe7536137e61ed',
      },
      {
        nodeCache: cacheManager.getCache('tmdb').data,
        rateLimit: {
          maxRequests: 20,
          maxRPS: 50,
        },
      }
    );
    this.locale = getSettings().main?.locale || 'en';
    this.discoverRegion = discoverRegion;
    this.originalLanguage = originalLanguage;
  }

https://github.com/seerr-team/seerr/blob/develop/server/api/themoviedb/index.ts#L138

[gauthier-th]

This is the intended behavior.
Please take a look at this discussion: #1250

[Patrick2052]

Thanks for the reply. Ok i didnt know exactly how tvdb handles it. Seems fine for now then :)