-
-
Notifications
You must be signed in to change notification settings - Fork 552
feat(episodes): add episode availability tracking and sync #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(episodes): add episode availability tracking and sync #1671
Conversation
|
This will not work properly when theres a mismatch between tvdb and tmdb right? Thats why our original plan was to wait till tvdb pr is merged until this feature. Unless you have some other ideas? (Haven't gone through the code yet) |
You’re absolutely right about the TVDB/TMDB mismatch concern - I considered that during implementation. Instead of relying on direct TMDB ID mapping, I leveraged the existing Sonarr connection via That said, I recognize there will be edge cases where TVDB and TMDB have inconsistent episode structures. I saw this as a pragmatic first step that covers most use cases. I thought about a few options moving forward: Wdyt ? |
I think this would be the better idea. Or it will cause an influx of support requests saying why is this episode not available when it is etc etc |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Can a preview be made for this PR when the merge conflicts are resolved? |
It still needs reviews and the merge of tvdb implementation's PR. |
|
The merge of the tvdb is done |
1b35dd4 to
84dc865
Compare
Now it is yes |
|
Following up on the previous comments about episode mismatch with TMDB: |
Yep, I think so. But we should be pretty clear about this - with a tooltip or something. |
6624144 to
5e586d6
Compare
|
@gauthier-th Just added a setting to make it optional. And sync only works when TVDB is set as metadata provider for either tv or anime. |
|
Isn't it weird to display an "error" badge when the episode is not available but not released yet? Or not requested yet? |
Would an airdate check be enough? IMO the "Unavailable" badge should still appear even if the episode hasn't been requested. This could be changed later as part of the "per-episode request feature" ? |
I mean, we don't write the status of a season when it's not requested. We only write "Requested" or "Available"/"Partially Available". Not a status in the error color, implying an error when it's "just" missing |
Ah, that makes sense - my mistake. I thought it might be a small UX improvement, but you're right, it could be misleading. |
5e586d6 to
2a62eb7
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
623b212 to
d390153
Compare
|
What a great feature ! Hype to be able to request single épisode later ! note: edited by a mod to keep in line with our community rules. |
This allows Jellyseerr to track the availability status of individual episodes, enabling better status reporting for partially available seasons.
The PR should not fix the issue reported in recent tvdb PR. Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
d390153 to
35d6b57
Compare
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
…ading Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
Description
This allows Jellyseerr to track the availability status of individual episodes, enabling better status reporting for partially available seasons.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed