fix(jellyfin sync): temporary workaround fix for jellyfin scan when display specials within season#347
Merged
fallenbagel merged 1 commit intodevelopfrom Mar 17, 2023
Conversation
…isplay specials within season Currently when display specials within season is enabled, it increases the indexed episode count of the season. This is a problem due to the way our jellyfin sync works as it requires total standard episodes to be equal to season episode count for the `AVAILABLE` badge for that season. However, when the display specials within season is enabled, the scan sets that season as `PARTIALLY AVAILABLE`. This workaround fixes this behaviour. In addition, this fix **might** also fix the recurring availability notifications (recurring notifications might be occurring due to the scan initially setting the season as available, thus the series is set as available and sends the notification, but then it sets the season as partially available due to the aforementioned sync flow until next scan and repeats.) fix #215 #176 #246
Collaborator
Author
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently when display specials within season is enabled, it increases the indexed episode count of the season. This is a problem due to the way our jellyfin sync works as it requires total standard episodes to be equal to season episode count for the
AVAILABLEbadge for that season. However, when the display specials within season is enabled, the scan sets that season asPARTIALLY AVAILABLE. This workaround fixes this behaviour.In addition, this fix might also fix the recurring availability notifications (recurring notifications might be occurring due to the scan initially setting the season as available, thus the series is set as available and sends the notification, but then it sets the season as partially available due to the aforementioned sync flow until next scan and repeats).
I have tested this fix locally and it has fixed the issue for me.
To-Dos
yarn buildIssues Fixed or Closed