Skip to content

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Oct 23, 2025

  • Added storage global object.
  • Added getValue(key), setValue(key, value), and removeValue(key) to said object.
  • Added tests.
  • Special cases for NSNull since UserDefaults doesn't support it, but its expected from the JS side.
  • Added internal conversion function to deal with UserDefaults use of class clusters.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 91.05691% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.73%. Comparing base (3a14ea3) to head (2bb39e6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Sources/AnalyticsLive/LivePlugins/StorageJS.swift 90.75% 11 Missing ⚠️

❌ Your project status has failed because the head coverage (39.73%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   37.60%   39.73%   +2.12%     
==========================================
  Files          38       39       +1     
  Lines        3303     2746     -557     
==========================================
- Hits         1242     1091     -151     
+ Misses       2061     1655     -406     
Files with missing lines Coverage Δ
...ources/AnalyticsLive/LivePlugins/LivePlugins.swift 96.40% <100.00%> (+1.77%) ⬆️
Sources/AnalyticsLive/LivePlugins/StorageJS.swift 90.75% <90.75%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bsneed bsneed merged commit e9bf9cb into main Oct 27, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants