This repository was archived by the owner on Nov 27, 2019. It is now read-only.
push userId to data layer for track calls #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://segment.atlassian.net/browse/INT-450
@sperand-io
fyi -- i think we should modify the ajs-tester so that it updates the
analytics.user()object when you callanalytics.identify(). Right now it does not do that, meaning that in thelib/indexI have to use theanalytics.user().id()to grab theuserIdvs. being able to just usetrack.userId()since the only way to test it is to set the id of the user object directly by usinganalytics.user().id(<ID>)Or the facade
.userId()function should fallback on checking theanalytics.userobject -- Right now it just looks up the.field('userId')DO NOT MERGE: waiting until rollout
TODO: