This repository was archived by the owner on Nov 27, 2019. It is now read-only.
send anonymousId automatically #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #5 diff @@
===================================
Files 1 1
Lines 24 26 +2
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 24 26 +2
Misses 0 0
Partials 0 0
|
lib/index.js
Outdated
| var userId = this.analytics.user().id(); | ||
| var anonymousId = this.analytics.user().anonymousId(); | ||
| if (userId) props.userId = userId; | ||
| if (anonymousId) props.anonymousId = anonymousId; |
There was a problem hiding this comment.
feels like we should call this segmentAnonymousId or something namespaced like that. Whereas userId is customer-dictated, this is a value we create and populate. thoughts @f2prateek?
Contributor
Author
There was a problem hiding this comment.
good point. I like the segmentAnonymousId idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sends
anonymousIdin addition touserIdaspropertiesfor.page()and.track()calls@sperand-io @brennan