Skip to content
This repository was archived by the owner on Nov 27, 2019. It is now read-only.

send anonymousId automatically #5

Merged
merged 3 commits into from
Aug 1, 2016
Merged

send anonymousId automatically #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dda3577
send anonymousId automatically
Aug 1, 2016
ffb3ac4
disable ie9 tests
Aug 1, 2016
3303384
change anonymousId namespace to segmentAnonymousId
Aug 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions karma.conf.ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ var customLaunchers = {
// browserName: 'internet explorer',
// version: '8'
// },
sl_ie_9: {
base: 'SauceLabs',
browserName: 'internet explorer',
version: '9'
},
// FIXME(han): these started to fail all of a sudden for what seems to be related to our testing packages
// https://cloudup.com/cFVvf3ixqdh
// sl_ie_9: {
// base: 'SauceLabs',
// browserName: 'internet explorer',
// version: '9'
// },
sl_ie_10: {
base: 'SauceLabs',
browserName: 'internet explorer',
Expand Down
6 changes: 4 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ GTM.prototype.page = function(page) {

GTM.prototype.track = function(track) {
var props = track.properties();
var id = this.analytics.user().id();
if (id) props.userId = id;
var userId = this.analytics.user().id();
var anonymousId = this.analytics.user().anonymousId();
if (userId) props.userId = userId;
if (anonymousId) props.segmentAnonymousId = anonymousId;
props.event = track.event();

push(props);
Expand Down
23 changes: 20 additions & 3 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,19 +63,28 @@ describe('Google Tag Manager', function() {
});

it('should send event', function() {
var anonId = analytics.user().anonymousId();
analytics.track('some-event');
analytics.called(window.dataLayer.push, { event: 'some-event' });
analytics.called(window.dataLayer.push, { segmentAnonymousId: anonId, event: 'some-event' });
});

it('should send userId if it exists', function() {
analytics.user().id('pablo');
var anonId = analytics.user().anonymousId();
analytics.track('some-event');
analytics.called(window.dataLayer.push, { userId: 'pablo', event: 'some-event' });
analytics.called(window.dataLayer.push, { segmentAnonymousId: anonId, userId: 'pablo', event: 'some-event' });
});

it('should send anonymousId if it exists', function() {
analytics.user().anonymousId('el');
analytics.track('stranger things');
analytics.called(window.dataLayer.push, { segmentAnonymousId: 'el', event: 'stranger things' });
});

it('should send event with properties', function() {
var anonId = analytics.user().anonymousId();
analytics.track('event', { prop: true });
analytics.called(window.dataLayer.push, { event: 'event', prop: true });
analytics.called(window.dataLayer.push, { segmentAnonymousId: anonId, event: 'event', prop: true });
});
});

Expand All @@ -91,9 +100,11 @@ describe('Google Tag Manager', function() {

it('should track unamed pages if enabled', function() {
gtm.options.trackAllPages = true;
var anonId = analytics.user().anonymousId();
analytics.page();
analytics.called(window.dataLayer.push, {
event: 'Loaded a Page',
segmentAnonymousId: anonId,
path: window.location.pathname,
referrer: document.referrer,
title: document.title,
Expand All @@ -103,9 +114,11 @@ describe('Google Tag Manager', function() {
});

it('should track named pages by default', function() {
var anonId = analytics.user().anonymousId();
analytics.page('Name');
analytics.called(window.dataLayer.push, {
event: 'Viewed Name Page',
segmentAnonymousId: anonId,
name: 'Name',
path: window.location.pathname,
referrer: document.referrer,
Expand All @@ -116,9 +129,11 @@ describe('Google Tag Manager', function() {
});

it('should track named pages with a category added', function() {
var anonId = analytics.user().anonymousId();
analytics.page('Category', 'Name');
analytics.called(window.dataLayer.push, {
event: 'Viewed Category Name Page',
segmentAnonymousId: anonId,
category: 'Category',
name: 'Name',
path: window.location.pathname,
Expand All @@ -130,10 +145,12 @@ describe('Google Tag Manager', function() {
});

it('should track categorized pages by default', function() {
var anonId = analytics.user().anonymousId();
analytics.page('Category', 'Name');
analytics.called(window.dataLayer.push, {
event: 'Viewed Category Name Page',
category: 'Category',
segmentAnonymousId: anonId,
name: 'Name',
path: window.location.pathname,
referrer: document.referrer,
Expand Down