This repository was archived by the owner on Nov 23, 2019. It is now read-only.
Use strict utm parser #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, but no idea what people might be depending on other params downstream? |
Contributor
|
hmm yeah it totally make sense to me. But I wonder if our tools right now support utm params that are custom? and if people have ad attribution funnels set up to be depending on those custom utm params, then this would break for them. if all ad tools abide by the same |
Contributor
|
@sperand-io this still relevant/can we ship after conflict resolve? |
Contributor
|
Closing for staleness. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only populate the 5 spec'd context.campaign fields when we parse the querystring. This PR adopts our utm parser's new strict mode to ensure that.
Our existing implementation will return an unbounded object with any key prefixed
utm_, causing, for example, unbounded column addition in redshift. This fix is especially important because customers are not in control of their own UTM params —any referrer can populate them erroneously and we see that happen often.@ndhoule @reinpk
cc/ @ivolo @wcjohnson11... you both were interested in seeing this fix through on slack :)