Skip to content

[refactory*] drop mess code and fix legency bugs #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2020
Merged

[refactory*] drop mess code and fix legency bugs #120

merged 5 commits into from
Nov 25, 2020

Conversation

@szdytom
Copy link
Contributor

@szdytom szdytom commented Nov 24, 2020 •
edited
Loading

This pr contains following changes:

  • rename components name
  • refactory lib message: stoping the requirement of pass this
  • fix 404 page code on deploy script
  • fix highlight bug at navbar
  • fix dependency: move some fake dev-dep to dep

@szdytom szdytom requested review from ZTL-UwU and gzezFISHER and removed request for gzezFISHER November 24, 2020 11:09
@szdytom szdytom added bug (Fix) something isn't working Code Style/Refactory This pr is to fix code style or refactory codes labels Nov 24, 2020
@szdytom szdytom requested a review from gzezFISHER November 24, 2020 11:10
@szdytom szdytom marked this pull request as ready for review November 24, 2020 11:10
@ZTL-UwU
Copy link
Contributor

ZTL-UwU commented Nov 25, 2020

This is one of the best PR in soj-frontend that I've ever seen!
Great job! Keep going!

@ZTL-UwU ZTL-UwU added the UX Improvements This PR is about UX label Nov 25, 2020
ZTL-UwU
ZTL-UwU approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ZTL-UwU ZTL-UwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ZTL-UwU ZTL-UwU merged commit 64bfdb2 into master Nov 25, 2020
@ZTL-UwU ZTL-UwU deleted the refactory-code-tom branch November 25, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZTL-UwU ZTL-UwU ZTL-UwU approved these changes

@gzezFISHER gzezFISHER Awaiting requested review from gzezFISHER

Assignees

No one assigned

Labels

bug (Fix) something isn't working Code Style/Refactory This pr is to fix code style or refactory codes UX Improvements This PR is about UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szdytom @ZTL-UwU