This repository was archived by the owner on Apr 24, 2024. It is now read-only.
adding test to retry on http error#107
Merged
lubird merged 6 commits intosegmentio:masterfrom Feb 7, 2020
Merged
Conversation
…Client (used for test)
…Standard20 project
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
======================================
Coverage 83.7% 83.7%
======================================
Files 32 32
Lines 583 583
======================================
Hits 488 488
Misses 95 95Continue to review full report at Codecov.
|
…ed event from being triggered
lubird
reviewed
Feb 3, 2020
| statusCode = (int)response.StatusCode; | ||
|
|
||
| if (response.StatusCode == HttpStatusCode.OK) | ||
| if (statusCode == (int)HttpStatusCode.OK) |
lubird
approved these changes
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.