Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Feature/lapp 15 Mock HttpClient#111

Closed
cgalan-applaudo wants to merge 6 commits intosegmentio:masterfrom
cgalan-applaudo:feature/LAPP-15
Closed

Feature/lapp 15 Mock HttpClient#111
cgalan-applaudo wants to merge 6 commits intosegmentio:masterfrom
cgalan-applaudo:feature/LAPP-15

Conversation

@cgalan-applaudo
Copy link
Copy Markdown
Contributor

Using a Mock instead to make a real Http request for unit tests

@cgalan-applaudo cgalan-applaudo changed the title Feature/lapp 15 Feature/lapp 15 Mock HttpClient Feb 21, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #111 into master will decrease coverage by 1.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   84.32%   83.09%   -1.24%     
==========================================
  Files          32       32              
  Lines         587      621      +34     
==========================================
+ Hits          495      516      +21     
- Misses         92      105      +13
Impacted Files Coverage Δ
...etStandard20/Request/BlockingRequestHandlerTest.cs 80.64% <ø> (ø) ⬆️
Test.NetStandard20/ConnectionTests.cs 100% <100%> (ø) ⬆️
Analytics/Client.cs 60% <100%> (+0.57%) ⬆️
Test.NetStandard20/ActionTests.cs 100% <100%> (ø) ⬆️
Analytics/Analytics.cs 62.5% <100%> (-37.5%) ⬇️
Test.NetStandard20/FlushTests.cs 92.3% <100%> (-2.82%) ⬇️
Analytics/Request/BlockingRequestHandler.cs 76.92% <0%> (-5.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b2ad8...ee5ca1c. Read the comment docs.

@cgalan-applaudo
Copy link
Copy Markdown
Contributor Author

This PR was included on #112

@cgalan-applaudo cgalan-applaudo deleted the feature/LAPP-15 branch March 6, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants