This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Conversation
f2prateek
previously approved these changes
Sep 21, 2018
Contributor
f2prateek
left a comment
f2prateek
left a comment
There was a problem hiding this comment.
LGTM! @fathyb @nhi-nguyen can you take a quick look as well?
fathyb
previously approved these changes
Sep 24, 2018
Contributor
Author
|
Hi, @f2prateek |
fathyb
previously approved these changes
Sep 27, 2018
nhi-nguyen
reviewed
Sep 27, 2018
| echo "Skipping end to end tests." | ||
| else | ||
| echo "Running end to end tests..." | ||
| wget https://github.com/segmentio/library-e2e-tester/releases/download/0.2.1/tester_linux_amd64 -O tester |
Contributor
There was a problem hiding this comment.
The latest version (0.2.2) should be used here.
nhi-nguyen
approved these changes
Sep 27, 2018
f2prateek
pushed a commit
that referenced
this pull request
Sep 28, 2018
* Generate coverage report and upload to codecov * Fix coverage job name * Fix bugs in generating coverage report * Fix generating xml report * Update resolve path for coverage * Update report path * Update root path for coverage * Fix coverage bash file path * Remove unnecessary file * Prevent restore unnecessary packages for test_35 and test_45 * Restore packages for current project only * Update coverage report type to opencover so that it can be parsed in codecov.io * E2e testing harness (#93) * Update E2E testing project to application type * Run E2E tester * Fix bug in e2e testing * Run analytics with system environment variables * Remove unused variable * Set execute permission with git * Remove parameters for e2e tester and use TESTER_xxx environment variables instead * Run codecov bash command directly * Use latest version of e2e tester * Generate coverage report and upload to codecov * Fix coverage job name * Fix bugs in generating coverage report * Fix generating xml report * Update resolve path for coverage * Update report path * Update root path for coverage * Fix coverage bash file path * Remove unnecessary file * Prevent restore unnecessary packages for test_35 and test_45 * Restore packages for current project only * Update coverage report type to opencover so that it can be parsed in codecov.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.