Fixes float and double serialization for some cultures #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecimal separator pt-BR for instance uses comma instead of dot as decimal separator
wenxi-zeng
approved these changes
Dec 3, 2025
Contributor
|
hi @gustavosantos-kazoo, sorry missed your pr completely. this is great! thanks for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
floatanddoubleserialization for cultures that usecommaas decimal separator.pt-BRfor instance usescommainstead ofdotas decimal separator.Also I added a unit test that checks in every available culture if a serialized number is always serialized with
dotinstead ofcomma. And its passing on every target platform.How JSON payload looked like before fix
This results in a payload rejection by server, due to malformed JSON.
How JSON payload looks like after fix